Openapi property based testing #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NelsonVides
reviewed
Jun 18, 2020
test/support/requests_generator.ex
Outdated
|
|
||
| # basic types | ||
| defp nonempty_string() do | ||
| StreamData.string(:alphanumeric) |> StreamData.filter(fn x -> String.length(x) > 0 end) |
There was a problem hiding this comment.
What about something like (or whatever the correct syntax is)
Suggested change
| StreamData.string(:alphanumeric) |> StreamData.filter(fn x -> String.length(x) > 0 end) | |
| StreamData.string(:alphanumeric, min_length: 1) |
Note that StreamData.string/2 can take the same options than list_of/1.
|
looks good. please recheck Nelson's suggestion. |
NelsonVides
force-pushed
the
openapi-property-based-testing
branch
from
b8988fd to
bba7d83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces property-based approach to APIv3 testing, with a little help of
StreamDataframework. I also incorporated the fix/enhancement of 'the hack of the hack' introduced in #168. Shortly speaking, the request containing, from the needed fields, onlydata,alert/bodyandalert/titlefields, was matched againstSilentNotificationschema, what has been leading to improperUnexpected field: alerterror.I also improved
ControllersHelper.missing_field_responsehelper function to better reflect possible error messages we can encounter during tests, basing on the API version being used.